Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UT for multimedia_utils #849

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add UT for multimedia_utils #849

merged 1 commit into from
Oct 24, 2023

Conversation

lumoslnt
Copy link
Contributor

Description

Add UT for multimedia_utils.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@lumoslnt lumoslnt requested a review from a team as a code owner October 23, 2023 03:50
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:50 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:50 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:50 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:50 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:50 — with GitHub Actions Inactive
@lumoslnt lumoslnt force-pushed the devs/linatang/add-ut-for-multimedia-utils branch from 830067b to a399589 Compare October 23, 2023 03:53
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:53 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:53 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:53 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:53 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 03:53 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Global Config Test Result devs/linatang/add-ut-for-multimedia-utils

2 tests   2 ✔️  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4fc493d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK PFS E2E Test Result devs/linatang/add-ut-for-multimedia-utils

8 tests   8 ✔️  32s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4fc493d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor Unit Test Result devs/linatang/add-ut-for-multimedia-utils

    2 files      2 suites   1m 53s ⏱️
391 tests 391 ✔️ 0 💤 0 ❌
760 runs  759 ✔️ 1 💤 0 ❌

Results for commit 4fc493d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Executor E2E Test Result devs/linatang/add-ut-for-multimedia-utils

    2 files      2 suites   7m 27s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit 4fc493d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

SDK CLI Test Result devs/linatang/add-ut-for-multimedia-utils

    2 files      2 suites   23m 46s ⏱️
305 tests 292 ✔️ 13 💤 0 ❌
610 runs  584 ✔️ 26 💤 0 ❌

Results for commit 4fc493d.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt force-pushed the devs/linatang/add-ut-for-multimedia-utils branch from a399589 to 4fc493d Compare October 23, 2023 06:03
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 06:03 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 06:03 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 06:03 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 06:03 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 23, 2023 06:03 — with GitHub Actions Inactive
@lumoslnt lumoslnt merged commit 883b15b into main Oct 24, 2023
31 checks passed
@lumoslnt lumoslnt deleted the devs/linatang/add-ut-for-multimedia-utils branch October 24, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaiyan huaiyan huaiyan approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumoslnt @thy09 @huaiyan